Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cl & deps++ #6582

Merged
merged 6 commits into from
Jul 2, 2020
Merged

cl & deps++ #6582

merged 6 commits into from
Jul 2, 2020

Conversation

alexanderbez
Copy link
Contributor


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez requested a review from tac0turtle July 2, 2020 15:08
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #6582 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6582   +/-   ##
=======================================
  Coverage   57.04%   57.04%           
=======================================
  Files         481      481           
  Lines       28939    28939           
=======================================
  Hits        16507    16507           
  Misses      11258    11258           
  Partials     1174     1174           

@alexanderbez
Copy link
Contributor Author

I'll fix the integration tests.

@tac0turtle tac0turtle mentioned this pull request Jul 2, 2020
9 tasks
@mergify mergify bot merged commit dacbcef into master Jul 2, 2020
@mergify mergify bot deleted the bez/cl-deps-bump branch July 2, 2020 19:35
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* cl & deps++

* Use PersistentPreRunE

* revert x/bank/client/cli/tx.go

* move to root level

* Use block mode by default

* Skip x/auth CLI tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants